feat!: adds support for description as a templatestring #43
+121
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberenice
reviewed
Jan 22, 2025
main.tf
Outdated
| enable_local_preview = try(local.stack_configs[each.key].enable_local_preview, var.enable_local_preview) | ||
| enable_well_known_secret_masking = try(local.stack_configs[each.key].enable_well_known_secret_masking, var.enable_well_known_secret_masking) | ||
| github_action_deploy = try(local.stack_configs[each.key].github_action_deploy, var.github_action_deploy) | ||
| labels = local.labels[each.key] | ||
| manage_state = try(local.stack_configs[each.key].manage_state, var.manage_state) | ||
| name = each.key | ||
| name = local.configs[each.key].root_module |
There was a problem hiding this comment.
Hm, I don't get this change. For multi-instance case we have one root module per multiple workspaces, and this is not a unique value.
Mind elaborating?
There was a problem hiding this comment.
You're correct! I could've just introduced a nasty bug... And honestly, we should have a test that avoids this.
I made this change as I thought it looked cleaner, but it's totally a bug. Thank you for the catch!!!! 💯
Will follow up with a fix + test.
There was a problem hiding this comment.
Fixed -- Thanks again @gberenice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.descriptionto be interpreted as atemplatestring.versions.tofubecausetemplatestringis introduced in v1.7 of tofu and 1.9 of terraform. We now need to manage these pins separately.why
references