Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention silent truncation of probing_rate>4 #803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions av1an/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,12 @@ pub struct CliOpts {
#[clap(long, default_value_t = 4, help_heading = "Target Quality")]
pub probes: u32,

/// Framerate for probes, 1 - original
#[clap(long, default_value_t = 1, help_heading = "Target Quality")]
/// Only use every nth frame for VMAF calculation, while probing.
///
/// WARNING: The resulting VMAF score might differ from if all the frames were used; usually it should be lower,
/// which means to get the same quality you must also usually lower the --target-quality. Going higher than
/// n=4 usually results in unusable scores, so this is disabled.
#[clap(long, default_value_t = 1, value_parser = clap::value_parser!(u16).range(1..=4), help_heading = "Target Quality")]
pub probing_rate: u32,

/// Use encoding settings for probes specified by --video-params rather than faster, less accurate settings
Expand Down