Limit event msg size & event number per operation #4768
+141
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilboquet
reviewed
Oct 28, 2024
| // Note on lifetimes: | ||
| // 'a -> is the lifetime for self -> because the iterator returns items from self | ||
| // 'b -> is the lifetime for filter -> because the returning iterator captures filter | ||
| // and we have lifetime 'a > 'b because filter can live less than self |
There was a problem hiding this comment.
do you mean "can't live"?
There was a problem hiding this comment.
No here lifetime 'b has the following bound: 'a: 'b. So it means that lifetime 'b can live less than lifetime 'a
bilboquet
reviewed
Oct 28, 2024
| @@ -1150,6 +1152,24 @@ impl Interface for InterfaceImpl { | |||
|
|
|||
| let mut context = context_guard!(self); | |||
| let event = context.event_create(data, false); | |||
There was a problem hiding this comment.
maybe move this line just after
if event_per_op >= self.config.max_event_per_operation {
bail!("Too many event for this operation");
}(only create the event if it's possible)
bilboquet
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.