Deferred calls #4723

modship · 2024-07-09T15:49:48Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

move reset of addr stack after event_emit

remove reset of created_event_index move event_emit

damip · 2024-10-29T10:30:40Z

massa-execution-worker/src/execution.rs

+                .storage_costs_constants
+                .ledger_cost_per_byte
+                .saturating_mul_u64(call.parameters.len() as u64);
+            context.transfer_coins(None, Some(call.sender_address), amount, false)?;


in what case does the "?" trigger in this case ?

damip · 2024-10-29T10:37:25Z

massa-execution-worker/src/execution.rs

+        if call.cancelled {
+            Ok(result)
+        } else {
+            let deferred_call_execution = || {


maybe extract this to another function for better clarity

modship · 2024-10-29T11:04:29Z

massa-execution-worker/src/speculative_deferred_calls.rs

@@ -486,10 +493,22 @@ impl SpeculativeDeferredCallRegistry {
            self.config.slot_overbooking_penalty, //   total_initial_coin_supply/10000
        )?;

+        // Storage cost for the parameters
+        let storage_cost = self


add total cost of call

plouis01 · 2024-10-29T17:36:08Z

massa-models/src/config/constants.rs

+/// deferred call min gas increment (1 nanomassa)
+pub const DEFERRED_CALL_MIN_GAS_INCREMENT: u64 = 1;
+/// deferred call max gas cost (10 nanomassa)
+pub const DEFERRED_CALL_MIN_GAS_COST: u64 = 10;


Is this DEFERRED_CALL_MIN_GAS_COST or the MAX as written in the commented part?

Is this DEFERRED_CALL_MIN_GAS_COST or the MAX as written in the commented part?

Hello @plouis01, indeed it is an error in the comment, I will update it

…TH to 255

AurelienFT and others added 12 commits May 9, 2024 18:13

Add structure async call and async call id

19e89b4

progress

4407e86

progress

b6948d0

todos

bcfaed3

Improve general behavior

eb59c84

typo

5315ea4

reformat registry

d4300c3

make things compile

60cbf28

updates

42c47cd

Merge remote-tracking branch 'aurelien/new_asc' into deferred_calls

37a1961

update new interface

94016cb

deferred calls first step

d62dbee

modship linked an issue Jul 9, 2024 that may be closed by this pull request

Develop autonomous contract with guaranteed execution on massa core massalabs/syntra#6

Open

modship added 17 commits July 9, 2024 17:56

rename massa_asc package to massa_deferred_calls

d18ed1b

TDD for ser_deser validation

8b3b2da

Test(DeferredRegistrySlotChanges) : Ser/deser

7d7e850

Test(DeferredRegistryChanges) : Ser/Deser

f945386

update StateChanges Deserializer

9814537

create macros, put_entry , delete_entry on DB

90202d3

refactor + get_total_gas

698a033

get_slot_calls && get_slot_base_fee

cfe824a

add mod tests / deferred_call_quote

1a86834

get_deferred_call_quote (interface_impl)

9d74423

register call

e1f2eca

register set gas

1bcc026

deferred_call_cancel

14ca8d5

execute deferred call, advance_slot, snapshot

4a0c7db

execution trace && execution info

ee901f1

delete call from DB

693cf0e

slot remaining gas for async msg

43923d1

modship added the Massa Foundation Mandated by the Massa Foundation label Sep 24, 2024

modship added 18 commits September 24, 2024 17:25

API : openrpc spec

4f7524d

grpc api

5b68c00

Fix grpc log error

815ed4c

API : Update list call ids by slot

fd9d945

rename openrpc method

ed88731

Fix : reset_to_snapshot

7cd95b3

move reset of addr stack after event_emit

Fix: reset_to_snapshot

08be8a9

remove reset of created_event_index move event_emit

FIX : Api double alloc vm cst

bc225ec

Fix : compute_fee get_effective_total_gas()

a4e21a3

Update runtime

a4f3a6d

Fix abi gas cost

34d9975

Test : compute_call_fee setup && first basic test

9e57b53

Test : add test for deferred call exists

6d25ee6

clippy

2aea5a0

Fix : fee calculation

46fccbe

add storage cost for deferred call

8ebf906

Merge remote-tracking branch 'origin/mainnet_2_3' into deferred_calls

2af6725

Storage: Refund sender (storage cost for params)

88ecb0d

modship changed the base branch from main to mainnet_2_3 October 18, 2024 10:42

modship added 4 commits October 21, 2024 11:00

Test : deferred call quote

ff28375

update runtime

64f4cdb

Fix all feature && update runtime

95e1bc8

fix doc

c8e45d8

damip reviewed Oct 29, 2024

View reviewed changes

modship commented Oct 29, 2024

View reviewed changes

plouis01 reviewed Oct 29, 2024

View reviewed changes

modship added 2 commits October 30, 2024 14:25

Update storage cost for deferred calls and set MAX_FUNCTION_NAME_LENG…

2453a80

…TH to 255

Fix comment

1ef9d71

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deferred calls #4723

Deferred calls #4723

modship commented Jul 9, 2024

damip Oct 29, 2024 •

edited

Loading

damip Oct 29, 2024

modship Oct 29, 2024

plouis01 Oct 29, 2024

modship Oct 30, 2024

Deferred calls #4723

Are you sure you want to change the base?

Deferred calls #4723

Conversation

modship commented Jul 9, 2024

damip Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

damip Oct 29, 2024

Choose a reason for hiding this comment

modship Oct 29, 2024

Choose a reason for hiding this comment

plouis01 Oct 29, 2024

Choose a reason for hiding this comment

modship Oct 30, 2024

Choose a reason for hiding this comment

damip Oct 29, 2024 •

edited

Loading