Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gas estimation and fix option deploy argument #604

Merged
merged 3 commits into from
May 16, 2024

Conversation

Ben-Rey
Copy link
Collaborator

@Ben-Rey Ben-Rey commented May 16, 2024

even when I put default value like waitFinalExecution it does not show on function description when used by dev. So I put default value in ts Doc

@Ben-Rey Ben-Rey changed the base branch from main to xp-new-version May 16, 2024 13:52
@Ben-Rey Ben-Rey requested a review from gregLibert May 16, 2024 13:52
@Ben-Rey Ben-Rey requested a review from gregLibert May 16, 2024 16:11
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

github-actions bot commented May 16, 2024

Coverage report for experimental massa-web3

St.
Category Percentage Covered / Total
🟢 Statements 83.81% 911/1087
🟡 Branches 73.87% 164/222
🟢 Functions 84.21% 176/209
🟢 Lines 83.96% 911/1085

Test suite run success

118 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 1a8f7c5

@gregLibert gregLibert merged commit 4b71486 into xp-new-version May 16, 2024
6 checks passed
@gregLibert gregLibert deleted the option-deploy branch May 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants