Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CallSmartContract #575

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Implement CallSmartContract #575

merged 8 commits into from
Apr 30, 2024

Conversation

Ben-Rey
Copy link
Collaborator

@Ben-Rey Ben-Rey commented Apr 26, 2024

No description provided.

@Ben-Rey Ben-Rey changed the base branch from main to xp-new-version April 26, 2024 11:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

Coverage report for experimental massa-web3

St.❔
 Category Percentage Covered / Total
🔴 Statements
39.87% (-6.65% 🔻)
 756/1896
🔴 Branches
17.92% (-3.84% 🔻)
 86/480
🔴 Functions
30.03% (-8.56% 🔻)
 112/373
🔴 Lines
39.62% (-6.72% 🔻)
 742/1873
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / args.ts
 17.58% 30.77% 5% 17.58%
🟡
... / index.ts
 77.78% 100% 0% 77.78%
🔴
... / strings.ts
 17.65% 0% 0% 17.65%
🔴
... / isNode.ts
 50% 0% 0% 50%
🔴
... / numbers.ts
 30.43% 0% 0% 30.43%
🔴
... / bignum.ts
 21.57% 0% 0% 21.57%
🔴
... / bool.ts
 50% 0% 0% 50%
🔴
... / arrays.ts
 12.63% 0% 0% 11.7%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / signature.ts
71.43% (+8.1% 🔼)
33.33% (+13.33% 🔼)
83.33% (-2.38% 🔻)
71.43% (+8.1% 🔼)
🟢
... / operationManager.ts
87.18% (-11.37% 🔻)
73.68% (-4.09% 🔻)
 100%
87.18% (-11.37% 🔻)

Test suite run success

48 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from c377250

@Ben-Rey Ben-Rey marked this pull request as ready for review April 26, 2024 12:03
@Ben-Rey Ben-Rey requested a review from peterjah April 26, 2024 14:46
@Ben-Rey Ben-Rey requested a review from gregLibert April 29, 2024 07:27
gregLibert
gregLibert suggested changes Apr 29, 2024
View reviewed changes
packages/massa-web3/src/experimental/basicElements/serializers/arrays.ts Show resolved Hide resolved
packages/massa-web3/src/experimental/basicElements/serializers/arrays.ts Show resolved Hide resolved
packages/massa-web3/src/experimental/basicElements/serializers/arrays.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/basicElements/serializers/arrays.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/basicElements/serializers/arrays.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/errors/insufficientBalance.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/smartContract.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/smartContract.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/smartContract.ts Outdated Show resolved Hide resolved
packages/massa-web3/src/experimental/smartContract.ts Outdated Show resolved Hide resolved
@Ben-Rey Ben-Rey force-pushed the feat/callsc branch 2 times, most recently from 8d0dc06 to bce86a2 Compare April 29, 2024 13:23
@Ben-Rey Ben-Rey requested a review from gregLibert April 29, 2024 13:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Ben-Rey Ben-Rey requested a review from gregLibert April 30, 2024 12:26
@Ben-Rey Ben-Rey merged commit 4821931 into xp-new-version Apr 30, 2024
6 checks passed
@Ben-Rey Ben-Rey deleted the feat/callsc branch April 30, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@gregLibert gregLibert gregLibert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ben-Rey @gregLibert @peterjah