Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

560 xp add sc manager #563

Merged
merged 8 commits into from
Apr 23, 2024
Merged

560 xp add sc manager #563

merged 8 commits into from
Apr 23, 2024

Conversation

gregLibert
Copy link
Contributor

No description provided.

@gregLibert gregLibert linked an issue Apr 19, 2024 that may be closed by this pull request
XP - add SC manager #560
Closed
@gregLibert gregLibert changed the base branch from main to 558-xp-add-operation-and-accoutmanager April 19, 2024 13:40
@gregLibert gregLibert force-pushed the 558-xp-add-operation-and-accoutmanager branch from db68a25 to a18b74a Compare April 19, 2024 16:48
@peterjah peterjah force-pushed the 558-xp-add-operation-and-accoutmanager branch 2 times, most recently from 44aa006 to e9955c2 Compare April 22, 2024 10:24
AurelienFT
AurelienFT reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review this whole PR given the fact that most of the changes are reflected on #559

packages/massa-web3/src/experimental/smartContract.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Coverage report for experimental massa-web3

St.❔
 Category Percentage Covered / Total
🔴 Statements
38.36% (-15.14% 🔻)
 539/1405
🔴 Branches
14.67% (-19.01% 🔻)
 54/368
🔴 Functions
26.15% (-27.34% 🔻)
 74/283
🔴 Lines
38.12% (-15.66% 🔻)
 528/1385
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 index.ts 94.74% 0% 11.76% 92.86%
🟢
... / IProvider.ts
 100% 100% 100% 100%
🟢
... / EOperationStatus.ts
 100% 100% 100% 100%
🟢
... / OperationTypes.ts
 100% 100% 100% 100%
🔴
... / ClientFactory.ts
 21.21% 0% 0% 21.21%
🔴 web3/Client.ts 15.79% 0% 0% 15.79%
🔴
... / PrivateApiClient.ts
 6.67% 0% 0% 6.67%
🔴
... / retryExecuteFunction.ts
 23.81% 0% 0% 20%
🔴 utils/time.ts 12.5% 0% 0% 12.9%
🟢
... / JsonRpcMethods.ts
 100% 100% 100% 100%
🔴 web3/BaseClient.ts 51.61% 10.26% 36.36% 51.61%
🟢 utils/Xbqcrypto.ts 89.47% 100% 60% 89.47%
🟢
... / index.ts
 100% 100% 100% 100%
🔴
... / signed.ts
 54.55% 0% 0% 54.55%
🔴
... / unsigned.ts
 57.58% 50% 66.67% 57.58%
🔴
... / keyAndAddresses.ts
 53.49% 33.33% 45.45% 53.49%
🔴 utils/bytes.ts 41.18% 0% 0% 41.18%
🔴
... / PublicApiClient.ts
 6.56% 0% 0% 6.56%
🔴
... / WalletClient.ts
 6.85% 0% 0% 6.94%
🔴
... / Web3Account.ts
 18.92% 0% 8.33% 19.18%
🔴
... / SmartContractsClient.ts
 9.7% 0% 0% 9.85%
🔴
... / operationStatus.ts
 50% 0% 0% 50%
🔴
... / WalletProviderAccount.ts
 8.7% 0% 0% 8.7%
🔴 web3/EventPoller.ts 10.91% 0% 0% 11.11%
🟢 utils/index.ts 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟡
... / address.ts
 79.49% 57.14% 85.71% 79.49%
🟢
... / base58.ts
 100% 100% 100% 100%
🟢
... / versioner.ts
 100% 100% 100% 100%
🟢
... / varintVersioner.ts
 100% 100% 100% 100%
🟢
... / internal.ts
 80% 0% 100% 80%
🔴
... / signature.ts
 23.81% 0% 0% 23.81%
🟡
... / keys.ts
 76.19% 57.14% 73.68% 76.19%
🟢
... / blake3.ts
 100% 100% 100% 100%
🟡
... / ed25519.ts
 66.67% 100% 50% 66.67%
🔴
... / operationManager.ts
 56.52% 27.78% 40% 56.52%
🔴
... / operation.ts
 25% 22.22% 10% 25%
🔴
... / storage.ts
 33.33% 100% 0% 33.33%
🟡
... / account.ts
 60.34% 30.77% 54.55% 60.34%
🔴
... / passwordSeal.ts
 55.56% 38.1% 83.33% 55.56%
🟡
... / cross-browser.ts
 59.57% 38.89% 87.5% 62.22%

Test suite run success

7 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 759bb9f

@Ben-Rey Ben-Rey force-pushed the 560-xp-add-sc-manager branch 3 times, most recently from caed084 to 7878aa8 Compare April 23, 2024 10:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Ben-Rey Ben-Rey merged commit 8c15084 into 558-xp-add-operation-and-accoutmanager Apr 23, 2024
6 checks passed
@Ben-Rey Ben-Rey deleted the 560-xp-add-sc-manager branch April 23, 2024 13:06
peterjah added a commit that referenced this pull request Apr 23, 2024
@gregLibert @Ben-Rey @peterjah
560 xp add sc manager (#563)
b9e8299 
* Add smart contract

* Fix review comments

* put back getEvents

* fix operation manager test

* fix bigint

* Move tests in right folder

* [xp] rename waitFinalExecution

* fix test by generating random secret key

---------

Co-authored-by: BenRey <[email protected]>
Co-authored-by: Pierre Seznec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT left review comments

@Ben-Rey Ben-Rey Ben-Rey left review comments

@peterjah peterjah peterjah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XP - add SC manager
4 participants
@gregLibert @AurelienFT @peterjah @Ben-Rey