API refactoring + missing features #16
Conversation
aoudiamoncef
force-pushed
the
feature/develop
branch
2 times, most recently
from
8f8396b
to
05d568f
Compare
aoudiamoncef
changed the title
aoudiamoncef
changed the title
|
Hi @damip we need a review and validation after the cleanup before starting the implementations in Massa core. We could see later the private service which is lot simpler than the public one, If we could validate It together, It'll speed up our developments |
| string message = 2; | ||
| } | ||
|
|
||
| // Empty |
There was a problem hiding this comment.
IIRC this type won't be used anymore on the ABI side when we will merge.
do you use it in any API?
There was a problem hiding this comment.
don't mind, I've found where you use it.
I though you use dedicated empty types?
There was a problem hiding this comment.
It's used in the API, so we could keep It at the moment. We created our Empty and Error type to not rely on google ones
| @@ -13,6 +13,17 @@ option php_namespace = "Com\\Massa\\Model\\V1"; | |||
| option ruby_package = "Com::Massa::Model::V1"; | |||
| option swift_prefix = "MMODEL"; | |||
|
|
|||
| // Massa error | |||
| message Error { | |||
There was a problem hiding this comment.
We also have an Error message on ABI side.
Where not currently using any code field, do you ?
I'm asking to prevent clash when we will merge
How do you discriminate 0 from None?
There was a problem hiding this comment.
We could share the same structure, the errors codes will be written later
There was a problem hiding this comment.
Yes we probably should share this type (and possibly others).
We need to sync a bit more maybe merging common types in a dedicated pr then having our own pr relying on it
I'm gonna open a pr on what we have on the abi side for you to see
There was a problem hiding this comment.
The only issue is : NativeAmount which is not present in testnet 24
|
It's time to merge this version to main in order to prepare the newer gRPC API |
This reverts commit 962de24.
aoudiamoncef
force-pushed
the
feature/develop
branch
from
bf2b57a
to
b055997
Compare
This PR should contains a pre prod version of our gRPC API, starting from this version, we'll try to avoid breaking changes to make the life of builders easier and they'll be able to use the latest version of Massa in the buildnet
closes massalabs/massa#4187