Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API refactoring + missing features #16

Merged
merged 73 commits into from
Jul 26, 2023
Merged

API refactoring + missing features #16

merged 73 commits into from
Jul 26, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Jun 16, 2023

This PR should contains a pre prod version of our gRPC API, starting from this version, we'll try to avoid breaking changes to make the life of builders easier and they'll be able to use the latest version of Massa in the buildnet

closes massalabs/massa#4187

@aoudiamoncef aoudiamoncef force-pushed the feature/develop branch 2 times, most recently from 8f8396b to 05d568f Compare June 23, 2023 08:43
@aoudiamoncef aoudiamoncef changed the title Add private service Finalize migration from JsonRPC + add QueryState Jun 26, 2023
@aoudiamoncef aoudiamoncef changed the title Finalize migration from JsonRPC + add QueryState API refactoring + missing features Jun 28, 2023
@aoudiamoncef
Copy link
Contributor Author

Hi @damip

we need a review and validation after the cleanup before starting the implementations in Massa core.

We could see later the private service which is lot simpler than the public one, If we could validate It together, It'll speed up our developments

@aoudiamoncef aoudiamoncef marked this pull request as ready for review June 29, 2023 16:22
string message = 2;
}

// Empty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this type won't be used anymore on the ABI side when we will merge.
do you use it in any API?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind, I've found where you use it.
I though you use dedicated empty types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the API, so we could keep It at the moment. We created our Empty and Error type to not rely on google ones

@@ -13,6 +13,17 @@ option php_namespace = "Com\\Massa\\Model\\V1";
option ruby_package = "Com::Massa::Model::V1";
option swift_prefix = "MMODEL";

// Massa error
message Error {
Copy link
Collaborator

@bilboquet bilboquet Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have an Error message on ABI side.
Where not currently using any code field, do you ?
I'm asking to prevent clash when we will merge

How do you discriminate 0 from None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could share the same structure, the errors codes will be written later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we probably should share this type (and possibly others).
We need to sync a bit more maybe merging common types in a dedicated pr then having our own pr relying on it
I'm gonna open a pr on what we have on the abi side for you to see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue is : NativeAmount which is not present in testnet 24

@aoudiamoncef
Copy link
Contributor Author

It's time to merge this version to main in order to prepare the newer gRPC API

@aoudiamoncef aoudiamoncef merged commit 8b938e2 into main Jul 26, 2023
1 of 2 checks passed
@aoudiamoncef aoudiamoncef deleted the feature/develop branch July 26, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: add final state hash
5 participants