Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean code while debugging #761

Merged
merged 1 commit into from
Jul 23, 2024
Merged

clean code while debugging #761

merged 1 commit into from
Jul 23, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jul 17, 2024

No description provided.

@Thykof Thykof self-assigned this Jul 18, 2024
pivilartisant
pivilartisant approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check i the removal of the callback triggers an infinite re-render if not already tested

@Thykof
Copy link
Contributor Author

Thykof commented Jul 19, 2024

I would check i the removal of the callback triggers an infinite re-render if not already tested

I tried, it's ok

@Thykof Thykof marked this pull request as ready for review July 19, 2024 16:52
@Thykof Thykof requested a review from peterjah July 19, 2024 16:52
@Thykof Thykof merged commit 1dad8de into ETH-symbol-for-bnb Jul 23, 2024
2 checks passed
@Thykof Thykof deleted the clean-code branch July 23, 2024 15:05
Thykof added a commit that referenced this pull request Jul 24, 2024
@Thykof
clean code while debugging (#761)
657abc8
Thykof added a commit that referenced this pull request Jul 29, 2024
@Thykof
ETH for bsc WETH (#760)
6683ea8 
* ETH for bsc WETH

* clean code while debugging (#761)

* update ui kit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@pivilartisant pivilartisant pivilartisant approved these changes

Assignees

@Thykof Thykof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thykof @peterjah @pivilartisant