-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global refactoring. Improved maintainability. #11
Open
yvasyliev
wants to merge
21
commits into
masecla22:master
Choose a base branch
from
yvasyliev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvasyliev
changed the title
Global refactoring. Improves maintainability.
Global refactoring. Improved maintainability.
Sep 1, 2022
Do you mind having a look over why there's some conflicts? I've had a look over your architecture, and I feel like it is really good, and we could really implement it. With the library being pretty much experimental, there's no worry for backwards compatibility! |
# Conflicts: # src/main/java/masecla/reddit4j/client/Reddit4J.java # src/main/java/masecla/reddit4j/objects/RedditComment.java
Fixed the confilcts. Probably it's a good option to create a separate branch to merge all these changes. |
Any progress on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I completely rewrote the codebase, renamed packages and classes.
I created few entities and API methods. Since there is no complete official Reddit API documentation, I don't think I can finish the work by myself. But I think it's a good start to finally write a stable version.
Here is a quickstart example: