small improvements for CRAN checks #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the Travis-CI setup for R on OS X has some problems so the failed checks do not appear to be due to my changes. The other checks on Travis-CI look ok as were the checks with R-release and R-devel that I ran on my own machine (Debian testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martin,
I noticed that CRAN checks for
ggpartyare producing a couple of NOTEs which were easy to address: OmitLazyDatainDESCRIPTION(because there is no data) and movesurvivalfromImportstoSuggestsas it is only used in a vignette.Looking at the vignettes I thought it would be good to add explicit
VignetteDependsdeclarations and bringVignetteIndexEntryinto sync with the actual document title.Best wishes,
Achim