Improve implementation with suggestion hints

markusweigelt · Dec 5, 2023 · 1cd2da6 · 1cd2da6
1 parent 79d8355
commit 1cd2da6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/KeyView.java b/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/KeyView.java
@@ -157,7 +157,8 @@ public boolean isEditable() {
     @Override
     public boolean isFilterable() {
         InputType inputType = getInputType();
-        if (InputType.MULTIPLE_SELECTION.equals(inputType) || InputType.ONE_LINE_SINGLE_SELECTION.equals(inputType)) {
+        if (InputType.MULTIPLE_SELECTION.equals(inputType) || InputType.MULTI_LINE_SINGLE_SELECTION.equals(
+                inputType) || InputType.ONE_LINE_SINGLE_SELECTION.equals(inputType)) {
             return settings.isFilterable(declaration.getId());
         }
         return false;

diff --git a/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/Settings.java b/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/Settings.java
@@ -116,9 +116,8 @@ boolean isEditable(String keyId) {
     boolean isFilterable(String keyId) {
         if (currentSettings.containsKey(keyId)) {
             return currentSettings.get(keyId).isFilterable();
-        } else {
-            return false;
         }
+        return false;
     }
 
 

diff --git a/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/xml/Setting.java b/Kitodo-DataEditor/src/main/java/org/kitodo/dataeditor/ruleset/xml/Setting.java
@@ -52,6 +52,11 @@ public class Setting {
     @XmlAttribute
     private Boolean editable;
 
+    /**
+     * This will present an input filter for the list of options in select fields if set to true. When entering text,
+     * the filter will display only those options that contain the entered text. This attribute exclusively works with
+     * keys that have an option list; for other keys, no action will occur.
+     */
     @XmlAttribute
     private Boolean filterable;