Wrong calculation of timezone transitions' DTSTART timestamp #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be a bug in the calculation of timezone transitions. According to the example in RFC 5545, section 3.6.5 (page 67ff.) the DTSTART timestamp should be using the previously valid timezone. The small code change did the trick for me. Maybe there's a more suitable solution.
|
Hi there. I haven't got any feedback for the last months, yet. Therefore I'd like to ask if there is any information missing that I can provide you with. Did you have a chance and some spare time to validate the RFC and my pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a bug in the calculation of timezone transitions.
According to the example in RFC 5545, section 3.6.5 (page 67ff.) the DTSTART timestamp should be using the previously valid timezone, not the current local time.
The small code change did the trick for me. Maybe there's a more suitable solution.