Fix code duplication #1141
Merged
Fix code duplication #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Lehmkuhl <[email protected]> Co-authored-by: Jenyamba <[email protected]> Co-authored-by: Tu Van <[email protected]> Co-authored-by: Cid Lopes <[email protected]>
PR Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @markshust ,
I see that you added to detect if the directory is not empty in the new project directory during installation in the lib/onelinesetup script in this PR #1140.
But on the 13 line onelinesetup script executes an HTTP request using curl
And within lib/template from 7 to 10 lines it again checks if the directory is empty. It is duplication code, are you sure that we need to detect if the directory is empty within the lib/onelinesetup?