-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra-settings script #1016
Add extra-settings script #1016
Conversation
PR Summary
|
1a67497
to
e8011d7
Compare
I like the ideas in this PR. However, I don't really like how this is in a non-descript "extra-settings" file. It feels a bit out of place & random. Does it make sense to rename this to And I don't think we need the elasticsearch command at all, because I think we can set this memory param as an environment variable at https://github.com/markshust/docker-magento/blob/master/compose/compose.yaml#L63. If so, it would make sense to just add this |
Hi, Mark! Thank you for your feedback.
|
Make shebang more portable, capitalized X in Xdebug.
Standardized OS check
Switched response logic around
I made a few updates to make the script more portable, consistent with the logic within other scripts, and simplify the logic. |
This script is designed to simplify the configuration of the Docker environment and related settings. The primary tasks it addresses are:
Docker Container IP Address:
Opening Port 9003 for Xdebug:
Increasing Virtual Memory Map Count for Elasticsearch:
User Instructions:
Execute the script to perform the necessary configurations.
Follow the prompts and choose options according to your preferences.
Verify that all tasks have been completed successfully.
Please feel free to reach out if you have any questions or suggestions for improving the script.