IE8 and IE10 scrollProperty transform bug fixes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getComputedStyle on IE10 returns matrix3d insead of matrix, so different elements elements need to be used for the x and y offsets in that case.
|
Thanks for the pull request! The IE10 fix looks great, but I'm not sure why you're trying to fix the 'transform' adapter for IE8 when it doesn't support CSS transforms at all. Am I missing something? |
|
I guess it's only appropriate to use the transform adapter after doing feature detection to make sure that transforms are supported. I was working on a project where we didn't bother with feature detection. Instead of degrading gracefully, IE8 would throw a JavaScript error that would halt processing of other scripts. Commit 42ede39 allowed our site to degrade more gracefully and retain more JavaScript functionality. If you prefer not to incorporate that change, I'm happy to update this pull request so it only includes the IE10 fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across some bugs in IE when using scrollProperty transform. These fixes are working for me and I thought you might want to incorporate them,
The matrix3d fix is based on this iscroll commit: cubiq/iscroll@d31d6e6