"Insert" export and binary blobs #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hempalex
pushed a commit
to hempalex/fbexport
that referenced
this pull request
Feb 10, 2021
Co-authored-by: Pedro Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to export a Firebird database to MySQL by using an SQL export ("Insert"), I found the binary blobs were not exported properly. Most notably, the null-bytes don't play too well with the "string" container.
This change replaces the string escaping for all kinds of strings in the SQL export to add a few more character escapes (heavily influenced by http://dev.mysql.com/doc/refman/5.7/en/string-literals.html since MySQL is my target for those exports).
Note : a similar change may be needed for CSV export. Also, C++ isn't necessarily my most used language, code style/improvements welcome ! :)