address comment

marin-ma · Oct 31, 2024 · 5f0bb06 · 5f0bb06
1 parent 67650d2
commit 5f0bb06
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/velox/row/CompactRow.cpp b/velox/row/CompactRow.cpp
@@ -640,8 +640,8 @@ int32_t CompactRow::serialize(vector_size_t index, char* buffer) {
 void CompactRow::serialize(
     vector_size_t offset,
     vector_size_t size,
-    char* buffer,
-    const size_t* bufferOffsets) {
+    const size_t* bufferOffsets,
+    char* buffer) {
   serializeRow(offset, size, buffer, bufferOffsets);
 }
 

diff --git a/velox/row/CompactRow.h b/velox/row/CompactRow.h
@@ -46,8 +46,8 @@ class CompactRow {
   void serialize(
       vector_size_t offset,
       vector_size_t size,
-      char* buffer,
-      const size_t* bufferOffsets);
+      const size_t* bufferOffsets,
+      char* buffer);
 
   /// Deserializes multiple rows into a RowVector of specified type. The type
   /// must match the contents of the serialized rows.

diff --git a/velox/row/benchmarks/UnsafeRowSerializeBenchmark.cpp b/velox/row/benchmarks/UnsafeRowSerializeBenchmark.cpp
@@ -193,7 +193,7 @@ class SerializeBenchmark {
       const std::vector<size_t>& rowSize,
       const std::vector<size_t>& offsets) {
     auto rawBuffer = buffer->asMutable<char>();
-    compactRow.serialize(0, numRows, rawBuffer, offsets.data());
+    compactRow.serialize(0, numRows, offsets.data(), rawBuffer);
 
     std::vector<std::string_view> serialized;
     for (auto i = 0; i < numRows; ++i) {

diff --git a/velox/row/tests/CompactRowTest.cpp b/velox/row/tests/CompactRowTest.cpp
@@ -99,7 +99,7 @@ class CompactRowTest : public ::testing::Test, public VectorTestBase {
       // Serialize with different range size.
       while (offset < numRows) {
         auto size = std::min<vector_size_t>(rangeSize, numRows - offset);
-        row.serialize(offset, size, rawBuffer, offsets.data() + offset);
+        row.serialize(offset, size, offsets.data() + offset, rawBuffer);
         offset += size;
         rangeSize = checkedMultiply<vector_size_t>(rangeSize, 2);
       }

diff --git a/velox/serializers/CompactRowSerializer.cpp b/velox/serializers/CompactRowSerializer.cpp
@@ -93,7 +93,7 @@ class CompactRowVectorSerializer : public IterativeVectorSerializer {
           offset += rowSize[index] + sizeof(TRowSize);
         }
         // Write row data for all rows in range.
-        row.serialize(range.begin, range.size, rawBuffer, offsets.data());
+        row.serialize(range.begin, range.size, offsets.data(), rawBuffer);
       }
     }
   }