fix: handle periodic cleanup for sessions

[mscolnick]

This may help #3623, but I have not tested yet.

I will test this manually in the meantime, and try to make a reliable test out of it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marimo-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2025 7:49pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
marimo-storybook	⬜️ Ignored (Inspect)	Visit Preview		Jan 30, 2025 7:49pm

[akshayka]

Perplexing bug; I would have thought that

marimo/marimo/_server/api/endpoints/ws.py

Lines 468 to 488 in 0d719dd

	if self.manager.mode == SessionMode.RUN:
	# When the websocket is closed, we wait session.ttl_seconds before
	# closing the session. This is to prevent the session from being
	# closed if the during an intermittent network issue.
	def _close() -> None:
	if self.status != ConnectionState.OPEN:
	LOGGER.debug(
	"Closing session %s (TTL EXPIRED)",
	self.session_id,
	)
	# wait until TTL is expired before calling the cleanup
	# function
	cleanup_fn()
	self.manager.close_session(self.session_id)
	session = self.manager.get_session(self.session_id)
	if session is not None:
	cancellation_handle = asyncio.get_event_loop().call_later(
	session.ttl_seconds, _close
	)
	self.cancel_close_handle = cancellation_handle

handled this case. Unless somehow the websocket's on_disconnect is not called?

[mscolnick]

womp - all these tests work locally. none work in CI