Remove redundant abstractions #243
Open
+103
−732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marein
force-pushed
the
remove-redundant-abstractions
branch
3 times, most recently
from
50235a0
to
94fc733
Compare
WebInterface now invokes the application layers directly. That's okay, because the bus interface already abstracts the other contexts, so there is no reason to put another layer in between, especially because the type information would be lost through this additional layer.
marein
force-pushed
the
remove-redundant-abstractions
branch
from
94fc733
to
b8a25bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebInterface now invokes the application layers directly. That's okay, because the bus interface already abstracts the other contexts, so there is no reason to put another layer in between, especially because the type information would be lost through this additional layer. Also, when moving a context to its own service, message types and clients will be generated from definition files. That also makes the current abstractions even more redundant.
Open tasks:
This layer is mentioned in the README file under Transition to Microservices. This must be rewritten.Not yet anymore with Restructure README #244.