Version assets #191
Merged
Version assets #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets are versioned using Symfony's AssetMapper. This adds the possibility to cached assets for a long period of time. The import map is built so that each domain can maintain its own assets to avoid merge conflicts. That will be used in future iterations. Icons aren't version as files like site.webmanifest aren't compiled.
This allows to add the polyfill only when the browser doesn't support import maps.
marein
commented
Oct 17, 2023
marein
commented
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets are versioned using Symfony's AssetMapper. This adds the possibility to cache assets for a long period of time. The import map is built so that each domain can maintain its own importmap to avoid merge conflicts. That will be used in future iterations.
Icons aren't versioned as files like
site.webmanifestaren't compiled.