No dnd off if manually activated #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify these are not the extension's settings/schema ID, but the desktop settings/schema ID for notifications (Do Not Disturb).
If the user already has Do Not Disturb active upon entering a screen sharing or recording session, do not turn it off when it ends. Use a setting to persist the DND state upon entering a screen sharing or recording session: a private class member would have lost the state upon a shell restart or the extension being disabled and reenabled.
|
Hmm, interesting, I actually thought about adding that behavior originally, but I must have forgotten 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user already has DND activated before a screen share or recording starts, do not turn it off when the session ends.
Note that this trivially conflicts with PR #3.