Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing justifications #407

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Dec 28, 2024

There must be a better way to do this in LinkML by now!

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • run SSSOM-Py test suite against the updated model

This is adding a number of newer justifications to the validation rules of the schema.

  • Ask LinkML community what the state of the art way to do this is!

There must be a better way to do this in LinkML by now!
Copy link
Contributor

@ehartley ehartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm also curious to know if LinkML has a better way to do this.

Copy link
Contributor

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked if there isn't any more missing justifications, and everything looks good.

@matentzn matentzn merged commit 06eb9ad into master Jan 10, 2025
3 checks passed
@matentzn matentzn deleted the add-missing-justifications branch January 10, 2025 13:12
@matentzn
Copy link
Collaborator Author

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants