-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SSSOM Extended Prefix Map #568
base: master
Are you sure you want to change the base?
Conversation
src/sssom/obo.epm.json
Outdated
@@ -5282,6 +5296,7 @@ | |||
"prefix_synonyms": [ | |||
"MEDLINE", | |||
"PubMed", | |||
"PubMed ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthoyt whitespace in a prefix, even if synonym?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fearing the pubmed ID with whitespace might cause issues, wanting @cthoyt feedback before proceeding
8a140ac
to
20d99f6
Compare
20d99f6
to
f3e409f
Compare
f3e409f
to
a497556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthoyt can you check my comments to see if I am on the wrong track somewhere?
"https://bioregistry.io/BCGO:", | ||
"https://bioregistry.io/bcgo:", | ||
"https://purl.obolibrary.org/obo/BCGO_", | ||
"https://www.ebi.ac.uk/ols/ontologies/bcgo/terms?iri=http://purl.obolibrary.org/obo/BCGO_" | ||
"https://www.ebi.ac.uk/ols/ontologies/bcgo/terms?iri=http://purl.obolibrary.org/obo/BCGO_", | ||
"https://www.ebi.ac.uk/ols4/ontologies/bcgo/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252F" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for all or many obo ontologies
@@ -399,8 +400,8 @@ | |||
"http://purl.bioontology.org/ontology/BTO/BTO:", | |||
"http://www.brenda-enzymes.org/ontology.php?ontology_id=3&id_go=", | |||
"http://www.ebi.ac.uk/ols/ontologies/bto/terms?iri=http://purl.obolibrary.org/obo/BTO_", | |||
"http://www.ebi.ac.uk/ols4/ontologies/bto/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252F", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong uri prefix
@@ -5282,6 +5302,7 @@ | |||
"prefix_synonyms": [ | |||
"MEDLINE", | |||
"PubMed", | |||
"PubMed ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthoyt do we really want to add prefixes with spaces?
@@ -5290,6 +5311,7 @@ | |||
"http://bio2rdf.org/pubmed:", | |||
"http://bioregistry.io/MEDLINE:", | |||
"http://bioregistry.io/PMID:", | |||
"http://bioregistry.io/PubMed ID:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks bad
This pull request updates sssom extended prefix map (epm). Make sure you run make tests manually.