Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN: fixes failing tests for get_* family of functions if servers are unresponsive #191

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

goergen95
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 52.94% and project coverage change: +1.20% 🎉

Comparison is base (d95a704) 73.47% compared to head (93245d2) 74.68%.

❗ Current head 93245d2 differs from pull request most recent head b40458e. Consider uploading reports for the commit b40458e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   73.47%   74.68%   +1.20%     
==========================================
  Files          43       43              
  Lines        1806     1817      +11     
==========================================
+ Hits         1327     1357      +30     
+ Misses        479      460      -19     
Files Changed Coverage Δ
R/calc_active_fire_counts.R 93.75% <ø> (ø)
R/calc_active_fire_properties.R 92.85% <ø> (ø)
R/calc_biome.R 94.73% <ø> (ø)
R/calc_deforestation_drivers.R 95.00% <ø> (ø)
R/calc_drought_indicator.R 88.23% <ø> (ø)
R/calc_ecoregion.R 97.77% <ø> (ø)
R/calc_elevation.R 88.88% <ø> (ø)
R/calc_landcover.R 94.11% <ø> (ø)
R/calc_mangroves_area.R 100.00% <ø> (ø)
R/calc_population_count.R 94.11% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goergen95
Copy link
Member Author

Good news: Using \dontshow{} and \dontrun{} tags would let us not run examples on CRAN, but in in our pkgdown workflow.
Bad news: As per r-lib/pkgdown#1540, pkgdown does not properly handle the \dontshow{} tag and the result looks really bad...

@goergen95
Copy link
Member Author

Could someone have a look at the build artifact and spare an opinion whether or not this improves readability for new users?

@goergen95
Copy link
Member Author

cleanest way is to go with \dontshow{} and \dontrun{} and maybe describe our use case in r-lib/pkgdown#2188 and ask/help with a fix.

I am merging this, and then prepare the next CRAN release

@goergen95 goergen95 merged commit 49e4229 into main Aug 28, 2023
8 checks passed
@goergen95 goergen95 deleted the cran-fixes branch August 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant