New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring and cleanup #1007

Merged

nyurik merged 2 commits into maplibre:main from nyurik:refactor

Nov 17, 2023

Member

nyurik commented Nov 16, 2023 •

edited

Loading

remove benchmarks - not used for now, will need to be rewritten
move some CLI settings to a separate struct
move config saving to a shared function
simplify zoom level CLI parsing
rename main.rs to be the same name as generated binary (we can have multiple bins later)

nyurik requested a review from sharkAndshark

November 16, 2023 23:48


          Minor refactoring

08f62e3

nyurik force-pushed the refactor branch from 49ed9bb to 08f62e3 Compare

November 16, 2023 23:49


          fix lints

7174dd7

sharkAndshark approved these changes

View reviewed changes

nyurik merged commit 7e25f4c into maplibre:main

18 checks passed

nyurik deleted the refactor branch

November 17, 2023 00:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet