Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase #938 (pmtiles) onto main #962

Closed
wants to merge 3 commits into from

Conversation

WebFreak001
Copy link

@WebFreak001 WebFreak001 commented Dec 26, 2024

supersedes #938, close #938, close #807

also fixes the bug mentioned by @bdon (see 2nd commit)

There is a UI issue right now where the pmtiles:// prefix sometimes appears in the modal data sources editor, sometime does not. Ideally the pmtiles:// prefix is totally hidden from the editor, letting you naturally input a HTTP or HTTPS URL of a .pmtiles archive, and the internal Style JSON state has the full pmtiles://https://... string. This requires some changes to the existing patches, PR welcome.

cc @nyurik

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I'll let others to chime in, and merge a bit later unless something serious is discovered

@HarelM
Copy link
Collaborator

HarelM commented Dec 27, 2024

This looks good, it would be better to have a test to cover the opening of this screen/flow.

@bdon
Copy link

bdon commented Dec 27, 2024

What I was referring to above: CleanShot 2024-12-27 at 13 58 07@2x

Where once a source is created, the pmtiles:// prefix shows up. Though it may make more sense this way since it maps directly to how a developer would specify it in the Style JSON. So not an essential change.

@WebFreak001
Copy link
Author

I think it's good with pmtiles://, since this is also what you'll need to have in the final actual json - I just tested this with actually making a style and it worked very well and the protocol prefix helped me not forget it 👍

@WebFreak001
Copy link
Author

rebase & improvements done in #938 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PMTiles in Editor
4 participants