Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tileSize field for raster and raster-dem tile sources (#946) #947

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

teyotan
Copy link
Contributor

@teyotan teyotan commented Oct 10, 2024

Launch Checklist

Add tileSize field for raster and raster-dem tile sources. Solves #946

Untitled

Not in this PR

i18n for Tile Size

  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@louwers louwers self-requested a review October 10, 2024 13:08
@louwers
Copy link
Collaborator

louwers commented Oct 10, 2024

Cool! I will try it out later today.

@HarelM
Copy link
Collaborator

HarelM commented Oct 10, 2024

Can you please add the tile size string to the en.json and run the refresh so I can tag the relevant traslators?

@HarelM
Copy link
Collaborator

HarelM commented Oct 11, 2024

ISO Code Language User
de German @josxha
en English @HarelM
fr French @lhapaipai
hr Hebrew @HarelM
ja Japanese @keichan34
zh Simplified Chinese @jieme

Folks, can you help please with the translation?

@nyurik
Copy link
Member

nyurik commented Oct 11, 2024

You may want to use https://translatewiki.net/ -- this is the tool used for tons of apps for translation, including wikipedia

src/locales/ja/translation.json Outdated Show resolved Hide resolved
src/locales/ja/translation.json Outdated Show resolved Hide resolved
src/locales/ja/translation.json Outdated Show resolved Hide resolved
HarelM and others added 3 commits October 11, 2024 10:15
@HarelM
Copy link
Collaborator

HarelM commented Oct 11, 2024

@nyurik I'm familiar with this project, but I'm not familiar with a good integration to github.
If this is something that you would like to push forward feel free to do so.
I've used crowdin, which works nice, but it's an overhead for developers I belive.
In any case, you are welcome to improve the current situation.

HarelM and others added 2 commits October 11, 2024 22:45
src/locales/de/translation.json Outdated Show resolved Hide resolved
src/locales/de/translation.json Outdated Show resolved Hide resolved
@HarelM HarelM merged commit 172d4d5 into maplibre:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants