localIdeographFontFamily: false to load CJK fonts #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would this change do to latin characters? Will they still be using the glyphs? |
|
@HarelM Thank you for checking this PR. |
|
Let's use this PR to update maplibre-gl to avoid introducing "as any", it should be a few days at max. |
|
4.1.2 should be available now. |
|
@HarelM Thank you for supporting! I've fixed. |
HarelM
approved these changes
Mar 26, 2024
|
Should be published in a few minutes, let me know if you encounter any issue with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #892
this changes works well for CJK fonts.