chore: add Rust CI and update cssparser dep and lock #3175

nyurik · 2025-01-24T05:40:18Z

bump to https://github.com/mazznoer/csscolorparser-rs/releases/tag/v0.7.0 and fix related code
update all lock file to latest with cargo update
validate that the rustutils crate is valid
add MSRV (tested with cargo msrv find + CI for it
ensure rustutils crate is not published, and set version to 0.0.0 as it has no internal version

.github/workflows/rust-ci.yaml

louwers

I understand this is part of setting up infrastructure for Rust development. Nevertheless, before enabling Rust tests on CI, we should probably actually have some tests?

* validate that the rustutils crate is valid * currently uses hardcoded CI script, but should move it all to justfile similar to many other similar crates * add MSRV (tested with `cargo msrv find` + CI for it * ensure rustutils crate is not published, and set version to 0.0.0 as it has no internal version

louwers

Can you update the developer docs on Rust? It's in rust.md

nyurik · 2025-01-24T21:45:26Z

fixed, thx. Eventually we may want to move some content to the rustutils/README.md

louwers · 2025-01-24T23:45:29Z

fixed, thx. Eventually we may want to move some content to the rustutils/README.md

During the last TSC meeting I suggested we should consolidate all developer documentation since it is really hard to browse README.md files sprinkled throughout the repo.

nyurik · 2025-01-24T23:48:19Z

ok, works for me

rustutils/justfile

github-actions · 2025-01-27T19:38:30Z

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0058         +0.0056             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3175-compared-to-main.txt

github-actions · 2025-01-27T19:38:44Z

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3175-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.1Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3175-compared-to-legacy.txt

nyurik requested a review from louwers January 24, 2025 05:40

nyurik force-pushed the rust-ci branch from a3b316f to b886290 Compare January 24, 2025 05:42

nyurik changed the title ~~chore: add Rust CI~~ chore: add Rust CI and update cssparser dep and lock Jan 24, 2025