-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updateImageSource
.
#271
Conversation
@CaviarChen Thanks for the contribution! I haven't had time to test this, yet, but the code looks good 👍 |
merged from the upstream and tested, everything works fine. |
A gentle ping on this. |
Sorry, I haven't had time to actually test this. I left a comment about the documentation. |
Changed as requested. However, I do spot an issue and I don't think I know this lib enough to know where went wrong. It seems that the |
Played with the example a bit and I think the bug is not introduced by my PR. |
ping |
Thank you for your patience! Just one more question: is the new asset file your own picture or licensed in a way that's compatible with the repo license? |
Ah that's a good question, I might just found it from google. I have no experence in this, do you have any recommanded way of finding pic for this? |
I guess you could search on wikimedia commons and use e.g. a CC0 licensed image |
Replaced the image, the new one is found here: https://commons.wikimedia.org/wiki/File:Sydney_Opera_House_(2017).jpg |
Thank you again for your contribution and patience! |
This PR includes: - Use the proper upstream for fultter-maplibre-gl, our image source PR is merged: maplibre/flutter-maplibre-gl#271 - Only trigger a rerender when needed. However, there are bugs when antimeridian is in the view, and it require some none trivial changes in the upstream lib: maplibre/maplibre-native#1681
This PR basically backports an existing function from https://github.com/flutter-mapbox-gl/maps.
Unlike that one, this does not suffer from mapbox/mapbox-maps-android#302 and it works nicely on both iOS and Android. The web version is still unimplemented, similar to existing image source related functions.
(Sorry a thing I'm building only requires
updateImageSource
on both iOS and Android.)