Scripting : Make MapEditor|TilesetEditor.currentWangSet and MapEditor|TilesetEditor.currentWangColorIndex writeable

[dogboydog]

Fix #4101

currentWangSet setter: seems to be working:

tiled.mapEditor.currentWangSet = tiled.activeAsset.tilesets[0].wangSets[0] 

Currently crashing, I'm doing something wrong setting the currentWangColorIndex Edit: working :

tiled.mapEditor.currentWangColorIndex  = 2 

I didn't see an existing public method to change the selection so I tried to make one based on reading the rest of the code in wangdock.cpp . Maybe I missed something existing or just have a logic error in my setter. Visually at least, it seems to change the color selection though.

Causes crash:

TODO (@dogboydog )

• Update NEWS
• Update scripting doc

[bjorn]

The error message is from QSortFilterProxyModel, and it says the QModelIndex you're using is from the wrong model. That's because mWangColorModel->colorIndex returns an index in the source model, which still needs to be mapped to the model used by the view (the mWangColorFilterModel).

I don't recall now what this sort-filter-model is used for (I couldn't immediately find a reason for it to exist in the current code). The easiest thing to do for now is to call mWangColorFilterModel->mapFromSource(index), as done in a slightly mode convoluted way in WangDock::editWangColorName.

Hmm, in fact, you could likely adjust WangDock::onColorCaptured, which is basically doing what you're after with WangDock::setCurrentWangColor.

Just note that there's an assert in WangColorModel::colorIndex, which should not be possible to trigger from script. Potentially we could just turn the assert into a regular condition and return QModelIndex() in that case.

[dogboydog]

Thanks, I think I implemented what you suggested. It's working without errors now.
I updated the scripting docs and NEWS.md

tiled_wangset._color.mp4

[bjorn]

There's one remaining issue with this change, which is that the docs for the TilesetEditor are adjusted, but the change affects the MapEditor.

Rather than just fixing the docs change, it would probably be worth looking into making the properties also writable for the TilesetEditor. :-)

[dogboydog]

Oh whoops. Sorry about that, I'll take a look.

[dogboydog]

Added and seems to work for me locally in the Tileset editor as well.