Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add reference to 'Add Output Index' script by eishiya #3912

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Mar 19, 2024

No description provided.

@eishiya
Copy link
Contributor

eishiya commented Mar 19, 2024

I don't think mentioning me by name is necessary, the script includes a credit. I also think the wording might mislead people into thinking they have to use the script, whereas it's only needed if they want to automate it, e.g. if they have a bunch of maps. Suggested alternate wording:
You can automate updating your existing rule maps with the "[Add Output Index](https://github.com/mapeditor/tiled-extensions/blob/master/AddOutputIndex.js)" script.

@bjorn bjorn merged commit bb543aa into mapeditor:master Mar 19, 2024
2 of 3 checks passed
@bjorn
Copy link
Member Author

bjorn commented Mar 19, 2024

@eishiya Whoops, read your comment the second after I merged it...

@bjorn bjorn deleted the docs-add-script-reference branch March 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants