RouteLegRefresh: added incidents #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1421 +/- ##
=========================================
Coverage 75.49% 75.49%
Complexity 874 874
=========================================
Files 124 124
Lines 3889 3889
Branches 577 577
=========================================
Hits 2936 2936
Misses 690 690
Partials 263 263
|
RingerJK
force-pushed
the
kyv-route-refresh-incidents
branch
from
ce6a8ad to
cf04f92
Compare
LukasPaczos
reviewed
May 11, 2022
RingerJK
force-pushed
the
kyv-route-refresh-incidents
branch
from
cf04f92 to
5327cb6
Compare
done |
RingerJK
force-pushed
the
kyv-route-refresh-incidents
branch
from
5327cb6 to
98a13a3
Compare
|
@RingerJK , what do you think about adding an example of json with incidents from Directions API and test if it can be serialised to the model? |
that's a good point. Extended current jsons with tests, check the branch |
LukasPaczos
approved these changes
May 11, 2022
|
Ah, could you please also add a changelog to unreleased? |
|
my bad, I didn't know we started to add changelog for mapbox-java, will cut another PR |
|
Thanks! It just started naturally, added a ticket to officially track this work - #1434. |
RingerJK
added a commit
that referenced
this pull request
May 11, 2022
|
changelog pull request #1435 |
RingerJK
added a commit
that referenced
this pull request
May 11, 2022
RingerJK
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.