feat/v3-cosmos #10
Open
feat/v3-cosmos #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - fixes to deploy testnet4 for agents ### Drive-by changes - truncating labels to length 63 - adding `.relayer` to `agentConfig.contextChainNames` ### Related issues - for hyperlane-xyz/issues#574 ### Backward compatibility Yes ### Testing Manual --------- Co-authored-by: Trevor Porter <[email protected]> Co-authored-by: Nam Chu Hoai <[email protected]>
- Adding Optimism Hook for MailboxV3 - dispatch function with hookMetadata - https://github.com/hyperlane-xyz/issues/issues/513 No None
daniel-savu
reviewed
Oct 25, 2023
| .await?; | ||
|
|
||
| let total_count = tx_search_result.total_count; | ||
| let last_page = total_count / 30 + (total_count % 30 != 0) as u32; | ||
| let last_page = total_count / PAGINATION_LIMIT as u32 |
There was a problem hiding this comment.
Just want to double check that it's ok to use 100 as the pagination limit here, given that @hashableric suggested 100 might cause payloads to be too big: #12 (comment)
There was a problem hiding this comment.
I haven't confirmed it exactly. However, when 30 transactions are queried, the payload is about 1.8MB. According to this calculation, when querying 100 transactions, you will have a payload of approximately 6MB.
Most gRPC servers have a payload limit of 4MB, which can cause errors depending on which chain node you are querying. @daniel-savu
There was a problem hiding this comment.
OMG it isnt GRPC yes Its quite enough for just http payload @daniel-savu
Merge upstream v3
Fix validator panicking if it has no balance, make `cargo clippy` happy
…orepo into trevor/fix-announcement-issues
…ues-1 Estimate gas usage when announcing
…orepo into trevor/fix-announcement-issues-1
Add Manta/Neutron config
…t-data Also decode base64-encoded events
…ues-1 Fix build, oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing