Api refinements #41

ivnsch · 2021-06-14T10:57:45Z

Starting a refinements iteration of recent work. So far:

Improving naming of signing functions. Using generate_sig to create signatures and sign_x to create signed objects.
Hiding the new api objects, so they can't be instantiated by Algonaut dependencies. algonaut_transaction doesn't seem to be the ideal place to keep them, but for now it might be fine.

Other suggestions?

manuelmauro

The consistent naming feels much better!

examples/wallet_backup.rs

src/lib.rs

For now uses api objects, will decouple gradually / on demand

Consistency with other builders

manuelmauro

Looks good!

algonaut_client/src/algod/v1/mod.rs

algonaut_transaction/src/api_models.rs

ivnsch added 2 commits June 14, 2021 12:46

Rename functions

ad9498a

Hide api models, remove nested exports

e485264

ivnsch requested a review from manuelmauro June 14, 2021 10:57

manuelmauro approved these changes Jun 14, 2021

View reviewed changes

examples/wallet_backup.rs Outdated Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

ivnsch added 3 commits June 16, 2021 14:33

Use root project path

0336402

Add transitionary domain layer to clients

6e1e4a5

For now uses api objects, will decouple gradually / on demand

Rename Txn in TxnBuilder

596ee3a

Consistency with other builders

manuelmauro requested changes Jun 17, 2021

View reviewed changes

algonaut_client/src/algod/v1/mod.rs Show resolved Hide resolved

algonaut_transaction/src/api_models.rs Outdated Show resolved Hide resolved

Rename module

8c59fb7

ivnsch requested a review from manuelmauro June 18, 2021 05:31

manuelmauro approved these changes Jun 19, 2021

View reviewed changes

manuelmauro merged commit b5d63a5 into main Jun 19, 2021

ivnsch mentioned this pull request Jun 19, 2021

Integration tests follow up fixes #42

Merged

ivnsch deleted the refinements branch June 19, 2021 21:19

Provide feedback