Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transitionDuration prop to RingProgress #7103

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

yorkeJohn
Copy link
Contributor

Support the transitionDuration prop on RingProgress (similar to SemiCircleProgress).

Note: also added return types in the following files in order to fix the TypeScript Compiler error The inferred type of "X" cannot be named without a reference to "Y". This is likely not portable. A type annotation is necessary.
@mantine-tests/core/src/render.tsx
@mantine/core/src/components/Popover/use-popover.ts
@mantine/core/src/components/Tooltip/use-tooltip.ts

Docs have also been updated.

@rtivital
Copy link
Member

rtivital commented Nov 9, 2024

Please keep changes that are only related to RingProgress, other components worked fine as is without modifications

@yorkeJohn
Copy link
Contributor Author

Type annotation changes were required in order to compile locally. These changes should be made regardless, but I can move them to another PR if you’d prefer?

@rtivital
Copy link
Member

rtivital commented Nov 9, 2024

I do not have any issue with local compilation, please remove these changes from the PR, if tests pass then these changes should not be made.

@yorkeJohn
Copy link
Contributor Author

OK, those changes have been reverted.

@rtivital rtivital merged commit e55fbe6 into mantinedev:master Nov 16, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants