[@mantine/core] Select: More stable useEffect dependency for search #4998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tracking down the issue mentioned in #4995 and discovered it was due to multiple renders caused by the useEffect hook.
Often times the
data
prop isn't a stable reference so using theoptionsLockup
which is derived from it in a useEffect was causing unnecessary renders.Instead, I have used the
selectedOption
in the dependency array which seems to be more stable even whendata
changes.