Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update clsx to v2 #4613

Closed
wants to merge 1 commit into from
Closed

Conversation

kachkaev
Copy link

@kachkaev kachkaev commented Aug 4, 2023

Release notes: https://github.com/lukeed/clsx/releases/tag/v2.0.0

Benefit: If a project is using the latest clsx version, there will be no duplicates in the node_modules folder and the bundle.

@rtivital
Copy link
Member

rtivital commented Aug 4, 2023

Benefit: If a project is using the latest clsx version, there will be no duplicates in the node_modules folder and the bundle.

I do not see a benefit here for version 6.x. If a project is not using the latest clsx version, we will introduce duplicates. 7.x versions will come with clsx 2.x

@kachkaev
Copy link
Author

kachkaev commented Aug 4, 2023

That’s fine, useful to know. I guess that using any of the version during the transition period is not ideal, but the cost of potential duplicates is quite low anyway. FYI: MUI updated clsx to v2 in semver-minor: mui/material-ui#38121

@rtivital
Copy link
Member

Thanks for submitting a PR, it is closed because one of these reasons:

  • The feature/bug fix has been implemented in 7.0.0
  • The feature is no longer relevant in 7.0.0
  • You haven't followed contribution workflow and did not discuss the feature with a maintainer before submitting the PR

@rtivital rtivital closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants