Skip to content

Commit

Permalink
Merge branch 'master' into feature/funnel-chart
Browse files Browse the repository at this point in the history
  • Loading branch information
Kenzo-Wada authored Sep 28, 2024
2 parents fd0671c + 6bdffea commit a4705d0
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 13 deletions.
2 changes: 1 addition & 1 deletion apps/mantine.dev/src/pages/contribute.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ First of all, thank you for showing interest in contributing to Mantine! All you

- Decide on what you want to contribute.
- If you would like to implement a new feature, discuss it with the maintainer ([GitHub Discussions](https://github.com/mantinedev/mantine/discussions/new) or [Discord](https://discord.gg/wbH82zuWMN)) before jumping into coding.
- After finalizing issue details, as you begin working on the code.
- After finalizing issue details, you can begin working on the code.
- Run tests with `npm test` and submit a PR once all tests have passed.
- Get a code review and fix all issues noticed by the maintainer.
- If you cannot finish your task or if you change your mind – that's totally fine! Just let us know in the GitHub issue that you created during the first step of this process. The Mantine community is friendly – we won't judge or ask any questions if you decide to cancel your submission.
Expand Down
10 changes: 5 additions & 5 deletions packages/@docs/styles-api/src/data/Dates.styles-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ export const DecadeLevelGroupStylesApi: StylesApiData<DecadeLevelGroupFactory> =
export const YearLevelGroupStylesApi: StylesApiData<YearLevelGroupFactory> = {
selectors: {
...CalendarHeaderStylesApi.selectors,
levelsGroup: 'Group of decades levels',
monthsList: 'Years list table element',
monthsListRow: 'Years list row element',
monthsListCell: 'Years list cell element',
levelsGroup: 'Group of years levels',
monthsList: 'Months list table element',
monthsListRow: 'Months list row element',
monthsListCell: 'Monthss list cell element',
monthsListControl: 'Button used to pick months and years',
},

Expand All @@ -125,7 +125,7 @@ export const YearLevelGroupStylesApi: StylesApiData<YearLevelGroupFactory> = {
export const MonthLevelGroupStylesApi: StylesApiData<MonthLevelGroupFactory> = {
selectors: {
...CalendarHeaderStylesApi.selectors,
levelsGroup: 'Group of decades levels',
levelsGroup: 'Group of months levels',
...MonthStylesApi.selectors,
},

Expand Down
5 changes: 0 additions & 5 deletions packages/@mantine/charts/src/PieChart/PieChart.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,3 @@
outline: 0;
}
}

.label {
fill: var(--mantine-color-white);
font-size: var(--mantine-font-size-xs);
}
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const MenuItem = polymorphicFactory<MenuItemFactory>((props, ref) => {
loop: ctx.loop,
dir,
orientation: 'vertical',
onKeyDown: _others.onKeydown,
onKeyDown: _others.onKeyDown,
})}
__vars={{
'--menu-item-color':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export const TagsInput = factory<TagsInputFactory>((_props, ref) => {
key={`${item}-${index}`}
withRemoveButton={!readOnly}
onRemove={() => {
setValue(_value.filter((i) => item !== i));
setValue(_value.splice(index, 1));
onRemove?.(item);
}}
unstyled={unstyled}
Expand Down

0 comments on commit a4705d0

Please sign in to comment.