Fix conjoin workspaces bug ornl next #38685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walshmm
added
ORNL Team
|
err I seemed to have pulled too many commits in my cherry-pick... |
* Added check to match bins before conjoining * Added the optional boolean argument to ConjoinWorkspaces * Fixed some of the failing python interface tests * Updated the documentation for ConjoinWorkspaces * Fixed the qt tests * Fixed tests for RunDescriptor.py * Fixed the conjoin workspaces c++ tests * Added a new test to verify error msg when bins don't match * Updated some files to fix system test failures * Updated SANSDarkRunSubtractionTest.py * Updated isis_reduction_steps.py * Fixed the doc tests * Updated Workspaces::matchingBins to accept shared_ptr * Added release note * Updated the release note to include algorithm link * Updated docs and release note Co-authored-by: Caila Finn <[email protected]> --------- Co-authored-by: Caila Finn <[email protected]>
It doesn't make any sense and just confused me
The function does not compare sizes of workspaces, so the comment was wrong.
walshmm
force-pushed
the
fix_conjoin_workspaces_bug_ornl_next
branch
from
095e703 to
2ff9bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ornl-next version of #38619 and #38478
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.