Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix class feature type #2331

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented Aug 26, 2024

capa JSON output with dnfile uses class_ instead of class for feature types. This PR fixes a bug that shows undefined for class feature types.

Example: rule encrypt data using AES via .NET in https://mandiant.github.io/capa/explorer/#/?rdoc=https://dpaste.org/wEWd9/raw

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@fariss fariss added the webui related to capa results web visualization label Aug 26, 2024
@mr-tz
Copy link
Collaborator

mr-tz commented Aug 26, 2024

can you explain the bug a bit more detailed please? is this an inconsistency in the result doc or just an assumption you made in the web ui?

@williballenthin williballenthin merged commit b4f60ec into mandiant:master Aug 26, 2024
3 checks passed
@williballenthin
Copy link
Collaborator

oh sorry @mr-tz. let's continue the discussion here (despite the fact i merged) and can make follow up PRs if necessary.

@fariss
Copy link
Collaborator Author

fariss commented Aug 26, 2024

Sorry for the lack of clarification here. Yes, this is an assumption I made thinking feature.class was used to denote the class used (e.g. System.Security.Cryptography.CryptoStream) but is actually feature.class_. There is no issues with the rdoc.

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 26, 2024

ok, great, thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webui related to capa results web visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants