Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: fix global search and add UI tweaks #2298

Merged
merged 4 commits into from
Aug 16, 2024
Merged

web: fix global search and add UI tweaks #2298

merged 4 commits into from
Aug 16, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented Aug 16, 2024 •
edited
Loading

closes #2288, #2289, #2290 and partially fixes #2287

This PR:

  • fixes global search in show capabilities by function
  • introduces search column filters in show capabilities by function (off by default)
  • uses a bold color separator
  • reintroduces the toggle icon (>)

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@fariss fariss changed the title Fixes 2288 2289 2290 web: fix global search and add UI tweaks Aug 16, 2024
mr-tz
mr-tz approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, but other than that LGTM!

@fariss fariss requested a review from mr-tz August 16, 2024 12:16
@mr-tz mr-tz merged commit 76bd146 into mandiant:master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fariss @mr-tz