Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add powershell support in VM-Install-Shortcut #871

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add powershell support in VM-Install-Shortcut #871

merged 1 commit into from
Mar 5, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Jan 26, 2024

This fixes #676

@emtuls emtuls requested a review from Ana06 January 26, 2024 05:01
@emtuls emtuls self-assigned this Jan 26, 2024
Ana06
Ana06 requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is going to simplify the code and help keeping packages consistent. 😄

I think we should not provide $executablePath as argument for PowerShell.

packages/common.vm/tools/vm.common/vm.common.psm1 Outdated Show resolved Hide resolved
@emtuls emtuls added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Feb 20, 2024
@emtuls emtuls mentioned this pull request Feb 27, 2024
Merged
@emtuls emtuls requested a review from Ana06 February 27, 2024 05:20
@emtuls emtuls force-pushed the unify-shortcut-format branch 3 times, most recently from 6906e4b to 13d831b Compare March 5, 2024 16:45
Ana06
Ana06 approved these changes Mar 5, 2024
View reviewed changes
packages/common.vm/tools/vm.common/vm.common.psm1 Outdated Show resolved Hide resolved
@emtuls emtuls requested a review from Ana06 March 5, 2024 17:18
Ana06
Ana06 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@Ana06 Ana06 merged commit 4e5a5ba into main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

Assignees

@emtuls emtuls

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify shortcut format
2 participants
@emtuls @Ana06