-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SigCheck w/ Zimmerman Tools #1199
base: main
Are you sure you want to change the base?
Conversation
8a98353
to
df410a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement, thanks for working on this @emtuls!! 💖
I do not like that we have a code that is long and complicated repeated in many packages. could you please add a helper function that we can reuse so that the code in every of the packages is simple and the complicated code is in a single place making it easier to maintain and understand? 🙏
Question: Why can't we use VM-Assert-Signature
for RegCool? It seem you didn't need to do anything special in this case 🤔
fdf1255
to
cac1ffb
Compare
I've modified the The alternative would have been its own function, but it would mimic the As for why we can't use it with |
cac1ffb
to
7f5cc50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Can we now use the helper function to simplify the packages that are already using signature verification (sysinternals, googlechrome, metasploit)?
@@ -7,4 +7,4 @@ $category = 'Forensic' | |||
$zipUrl = 'https://download.mikestammer.com/net6/PECmd.zip' | |||
$zipSha256 = 'e20254b2f813e66fe5295488e5a00e9675679c91841f99ddcc8d083299bb55d6' | |||
|
|||
VM-Install-From-Zip $toolName $category $zipUrl -zipSha256 $zipSha256 -consoleApp $true -innerFolder $false | |||
VM-Install-From-Zip $toolName $category $zipUrl -zipSha256 $zipSha256 -consoleApp $true -innerFolder $false -verifySignature $true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to make the hash optional and remove it from the packages using signature verification:
VM-Install-From-Zip $toolName $category $zipUrl -zipSha256 $zipSha256 -consoleApp $true -innerFolder $false -verifySignature $true | |
VM-Install-From-Zip $toolName $category $zipUrl -consoleApp $true -innerFolder $false -verifySignature $true |
<authors>Eric Zimmerman</authors> | ||
<description>Prefetch parser</description> | ||
<dependencies> | ||
<dependency id="common.vm" version="0.0.0.20240411" /> | ||
<dependency id="common.vm" version="0.0.0.20241212" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to ensure signtool is installed in all the packages that use signature verification
<dependency id="common.vm" version="0.0.0.20241212" /> | |
<dependency id="common.vm" version="0.0.0.20241212" /> | |
<!-- vcbuildtools.vm installs signtool.exe needed by VM-Assert-Signature --> | |
<dependency id="vcbuildtools.vm" /> |
This fixes many of the tools that are running into an error in our Daily checks (https://github.com/mandiant/VM-Packages/wiki/Daily-Failures). These specific tools run into an issue where we need to manually update the hashes due to the links not having a version in them so our updater does not properly update the packages for us.
Specifically, this fixes:
evtxecmd.vm
pecmd.vm
recmd.vm
registry_explorer.vm
rla.vm
sqlecmd.vm