Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipython.vm #1143

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add ipython.vm #1143

merged 1 commit into from
Oct 23, 2024

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Oct 1, 2024

Closes #286.

@d35ha d35ha added 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Oct 1, 2024
@d35ha d35ha self-assigned this Oct 1, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it locally and it works as expected 🎉 not sure why it didn't work last time I tried it: #286 (comment) 😕

packages/ipython.vm/ipython.vm.nuspec Outdated Show resolved Hide resolved
Import-Module vm.common -Force -DisableNameChecking

$toolName = 'ipython'
$category = 'Productivity Tools'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a shortcut for ipython in the Productivity Tools folder? I personally think we don't and that we should directly use VM-Pip-Install ipython instead. But what do others think? @mr-tz @mandiant/vms opinions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ana06
By default, ipython is installed and available from the command line (I believe it is a dependency for another installed python library). This package installs its shortcut under Productivity Tools.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should always test new packages in an empty VM as documented in https://github.com/mandiant/VM-Packages/wiki/Testing#local-testing. The users can select the packages to install when installing FLARE-VM and commando VM uses different packages as well. In a VM with FLARE-VM and only the following packages I do not have ipython available:

Boxstarter|3.0.3
Boxstarter.Bootstrapper|3.0.3
Boxstarter.Chocolatey|3.0.3
Boxstarter.Common|3.0.3
Boxstarter.HyperV|3.0.3
Boxstarter.WinConfig|3.0.3
chocolatey|2.3.0
chocolatey-compatibility.extension|1.0.0
chocolatey-core.extension|1.4.0
chocolatey-windowsupdate.extension|1.0.5
common.vm|0.0.0.20240913
debloat.vm|0.0.0.20240327
hashmyfiles.vm|0.0.0.20240411
installer.vm|0.0.0.20240402
KB2919355|1.0.20160915
KB2919442|1.0.20160915
KB2999226|1.0.20181019
KB3033929|1.0.5
KB3035131|1.0.3
pma-labs.vm|0.0.0.20240411
python3|3.10.11
python3.vm|0.0.0.20240726
python310|3.10.11
vcredist140|14.40.33810
vcredist2015|14.0.24215.20170201

I hadn't noticed that the default configuration installs ipython. I wonder which package is installing it. Any clues @mandiant/vms?

Copy link
Member

@emtuls emtuls Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d35ha Is the shortcut useful?

I personally haven't used iPython directly, I think only as part of Jupyter Notebooks, so I'm not too familiar with how often it gets used directly.

Might be worth seeing if others would find it useful. Not opposed to it, just not sure if it's necessary and might just add clutter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally use it, it is a way better than the traditional python shell.

Copy link
Member

@Ana06 Ana06 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d35ha I assume you mean you use IPython and not the shortcut. I personally think IPython does not need a shortcut and that this package should only install it. But if seems @d35ha feels strong about it and @emtuls is ok with keeping it, so it is ok for me too.

@emtuls emtuls merged commit 81b81be into mandiant:main Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package idea: ipython
3 participants