-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipython.vm #1143
Add ipython.vm #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it locally and it works as expected 🎉 not sure why it didn't work last time I tried it: #286 (comment) 😕
Import-Module vm.common -Force -DisableNameChecking | ||
|
||
$toolName = 'ipython' | ||
$category = 'Productivity Tools' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a shortcut for ipython in the Productivity Tools folder? I personally think we don't and that we should directly use VM-Pip-Install ipython
instead. But what do others think? @mr-tz @mandiant/vms opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ana06
By default, ipython is installed and available from the command line (I believe it is a dependency for another installed python library). This package installs its shortcut under Productivity Tools
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should always test new packages in an empty VM as documented in https://github.com/mandiant/VM-Packages/wiki/Testing#local-testing. The users can select the packages to install when installing FLARE-VM and commando VM uses different packages as well. In a VM with FLARE-VM and only the following packages I do not have ipython available:
Boxstarter|3.0.3
Boxstarter.Bootstrapper|3.0.3
Boxstarter.Chocolatey|3.0.3
Boxstarter.Common|3.0.3
Boxstarter.HyperV|3.0.3
Boxstarter.WinConfig|3.0.3
chocolatey|2.3.0
chocolatey-compatibility.extension|1.0.0
chocolatey-core.extension|1.4.0
chocolatey-windowsupdate.extension|1.0.5
common.vm|0.0.0.20240913
debloat.vm|0.0.0.20240327
hashmyfiles.vm|0.0.0.20240411
installer.vm|0.0.0.20240402
KB2919355|1.0.20160915
KB2919442|1.0.20160915
KB2999226|1.0.20181019
KB3033929|1.0.5
KB3035131|1.0.3
pma-labs.vm|0.0.0.20240411
python3|3.10.11
python3.vm|0.0.0.20240726
python310|3.10.11
vcredist140|14.40.33810
vcredist2015|14.0.24215.20170201
I hadn't noticed that the default configuration installs ipython. I wonder which package is installing it. Any clues @mandiant/vms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d35ha Is the shortcut useful?
I personally haven't used iPython directly, I think only as part of Jupyter Notebooks, so I'm not too familiar with how often it gets used directly.
Might be worth seeing if others would find it useful. Not opposed to it, just not sure if it's necessary and might just add clutter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally use it, it is a way better than the traditional python shell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #286.