Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify shortcut format #676

Closed
Ana06 opened this issue Sep 29, 2023 · 4 comments · Fixed by #871
Closed

Unify shortcut format #676

Ana06 opened this issue Sep 29, 2023 · 4 comments · Fixed by #871
Assignees
Labels
🌀 COMMANDO-VM A package or future to be used by COMMANDO VM 🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Sep 29, 2023

VM-Install-Shortcut ensures shortcuts are created always in the same way. I personally find it useful to display the executed command for console applications as some times the help message does not include how to re-run the tool.

VM-Install-Single-Ps1 and VM-Install-Raw-GitHub-Repo use Install-ChocolateyShortcut (instead of VM-Install-Shortcut) to run with Powershell. VM-Install-Single-Ps1 Powershell with cmd while VM-Install-Raw-GitHub-Reporuns Powershell directly. I find it confusing not to know what they run as in any of them the executed command is not displayed (I can check the shortcut, but I think this is not obvious for all users and also not a nice way to do it).

I suggest we add a Powershell option to VM-Install-Shortcut that renders what is being executed and uses Powershell directly.

@Ana06 Ana06 added 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed labels Sep 29, 2023
@Ana06 Ana06 added this to the FLARE-VM 2023 Q4 milestone Sep 29, 2023
@Ana06 Ana06 self-assigned this Sep 29, 2023
@Ana06
Copy link
Member Author

Ana06 commented Oct 17, 2023

Documenting discussion with @MalwareMechanic:

  • We agree that it's useful to display what commands get executed when a LNK is clicked
  • We agree that shortcut helpers should be unified to support PowerShell as the default prompt

@Ana06 Ana06 added 🌀 FLARE-VM A package or feature to be used by FLARE-VM 🌀 COMMANDO-VM A package or future to be used by COMMANDO VM labels Oct 17, 2023
@Ana06
Copy link
Member Author

Ana06 commented Oct 18, 2023

The metapackage template is using Install-ChocolateyShortcut. We probably want to update it to use VM-Install-Shortcut instead.

@Ana06
Copy link
Member Author

Ana06 commented Jan 4, 2024

This comment from #800 (comment) could be checked/addressed when addressing this issue:

the cd not needed because we have it already in -WorkingDirectory $executableDir? If so, we should change this in VM-Install-Shortcut.

@Ana06
Copy link
Member Author

Ana06 commented Jan 22, 2024

@emtuls this issue is related to other issues you have worked on recently. I had assigned to myself, but I won't have time in the next weeks. So if you have time, please take it! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 COMMANDO-VM A package or future to be used by COMMANDO VM 🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants