Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special 'Favorites' folder being empty upon syncing #32

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix special 'Favorites' folder being empty upon syncing #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions icloudpy/services/photos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ def albums(self):
"""Returns photo albums."""
if not self._albums:
self._albums = {}
for (name, props) in self.SMART_FOLDERS.items():
self._albums[name] = PhotoAlbum(self, name, **props)

for folder in self._fetch_folders():

Expand All @@ -191,6 +189,7 @@ def albums(self):
folder_name = base64.b64decode(
folder["fields"]["albumNameEnc"]["value"]
).decode("utf-8")

query_filter = [
{
"fieldName": "parentId",
Expand All @@ -210,6 +209,9 @@ def albums(self):
)
self._albums[folder_name] = album

for (name, props) in self.SMART_FOLDERS.items():
self._albums[name] = PhotoAlbum(self, name, **props)

return self._albums

def _fetch_folders(self):
Expand Down