-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support example/examples on content value body request #87
Merged
manchenkoff
merged 12 commits into
manchenkoff:master
from
thaichat04:add-example-content-value
Sep 5, 2024
Merged
Add support example/examples on content value body request #87
manchenkoff
merged 12 commits into
manchenkoff:master
from
thaichat04:add-example-content-value
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @thaichat04, thanks a lot for the contribution! However, there are some failing tests since you extended the data class. Please, take a look and we are ready to go! |
Thanks, I didn't see tests failed. Sorry |
There are still some errors after your last commit:
you can run them locally via
|
manchenkoff
requested changes
Sep 2, 2024
manchenkoff
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #86: