Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barrier: Add barrier class #25

Merged
merged 1 commit into from
Jan 14, 2025
Merged

barrier: Add barrier class #25

merged 1 commit into from
Jan 14, 2025

Conversation

avdgrinten
Copy link
Member

Add a synchronization class similar to std::barrier.

@avdgrinten avdgrinten requested a review from qookei January 13, 2025 08:17
qookei
qookei reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but it'd be nice to have some docs and maybe a test for this.

@no92 no92 mentioned this pull request Jan 13, 2025
Merged
@avdgrinten
Copy link
Member Author

Makes sense. I'll merge this now since the Managarm PR needs to but I'll add docs and tests afterwards.

@avdgrinten avdgrinten merged commit 143433d into managarm:master Jan 14, 2025
2 checks passed
@avdgrinten avdgrinten deleted the barrier branch January 14, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qookei qookei qookei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdgrinten @qookei